James M. Greene comments

Results 457 comments of


                                            James M. Greene

Invalid artifact URL with v1.2.9

@jcop @Anubiso Actually, question for each of you: Does your artifact exchange URL's hostname (masked as `***.com` in the OP) **exactly** **match** your GHES appliance's hostname? e.g. both are exactly...

Implement `HTMLElement` `offsetWidth`, `offsetHeight`, `offsetTop`, and `offsetLeft`

@throrin19: Read through #653.

Add sanitization, validation, and basic tests for the `error_count` input parameter

@TWiStErRob Understandable confusion, but the behavior you're describing would be achieved with `error_count: 1`. In other words, "fail on the first error".

Add post hook to cancel in-progress deployments if the job/workflow run ends unsuccessfully

This is probably even more important than I originally thought as Pages self-regulates the concurrency of in-progress deployments to one per repository + branch/ref. As such, if you had an...

Add post hook to cancel in-progress deployments if the job/workflow run ends unsuccessfully

Haven't been able to reproduce in the recent past. 🤷

Unknown error when setting up NextJS config

@vicb Alas, I'm no longer on the Pages team, so can't help you there. 👋🏻 @yoannchaudet Anything the team will be able to look at soon, or would you perhaps...

Remove excess permissions from pages workflows

@jsoref I don't have the permissions to approve/merge anymore, but I'll reach out to my old team to see if anyone can get to it soon.