James M. Greene
James M. Greene
Isn't your `if` condition backward?
Oh, I suppose `chdir` returns `1` for errors rather than `false`, huh? If so, my mistake.
Gotcha, sorry for the confusion!
That's actually why I commented: I forked the repo and was going to start merging pull requests into my own version of it, so I wanted to verify the correctness...
Noted, thanks!
@coderaiser: If you're interested, you can check out my fork now: - https://github.com/JamesMGreene/node-partty - https://www.npmjs.com/package/partty
P.S. Doing this is part of offering full support for React Native: https://github.com/facebook/react-native/issues/526
Related nedb-core commit: https://github.com/nedbhq/nedb-core/commit/1049fc7e5384db693d008b236745436112ea8d2b
May want to consider alternative packages if they suit the needs, e.g. - [functional-red-black-tree](https://www.npmjs.com/package/functional-red-black-tree) - Notably used by `eslint` and `memdown` - [bintrees](https://www.npmjs.com/package/bintrees) - [avl](https://www.npmjs.com/package/avl) - [bbtree](https://www.npmjs.com/package/bbtree)
If sticking with the implementation from `binary-search-tree`, then also incorporate the following open PRs from that project: - https://github.com/louischatriot/node-binary-search-tree/pull/4 - https://github.com/louischatriot/node-binary-search-tree/pull/5 - https://github.com/louischatriot/node-binary-search-tree/pull/12 - https://github.com/louischatriot/node-binary-search-tree/pull/16 - Fixes existing issue https://github.com/louischatriot/node-binary-search-tree/issues/7...