James Kyburz

Results 23 comments of James Kyburz

At the time I wrote this this aws-sdk shipped with lambda didn't include the [management api for api gateway 2](https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ApiGatewayManagementApi.html) Maybe we should remove it, the code uses another function...

> thanks for your PR @JamesKyburz - I've added a few comments, please let me know what do you think. > > I think the better approach would be to...

Sorry for the delay :) `PR` rebased and updated. Added the option only to `lib/cli/commands-schema/common-options/aws-service.js` - [x] test:ci passes

@ajredniwja Thanks, I have quite a long exclude list when deploying lambdas the keep the size down :) Some of them are ```yaml - '!./**/node_modules/typescript' - '!./**/node_modules/@types' - '!./**/node_modules/@aws-sdk/**/dist-es' -...

A good start would be making sure all relative imports use file extensions `.js`, which is required by vanilla esm, and works in typescript too.

It's probably related to me not having time to update ytdl-core manually... (This has now been automated). Can you test again with the latest version please?

I will check if a PAT works using a Dependabot secret, if so maybe we could just update the README to reflect the v3 changes.

It does work with a dependabot specific repository secret PAT :) Also if this is used then you don't need to specify extra permissions because the rights given by the...

@simoneb I agree, although I can't think of any other solution either. I am also yet to find a way to automatically rotate PAT secrets too ☹️