James Henry

icon indicating a website link https://jameshenry.blog icon indicating an email [email protected]

icon company @nrwl icon location ☁️ icon location Director of Engineering at Nx (@nrwl). 5x MVP for TypeScript @microsoft. Creator of @typescript-eslint and @angular-eslint.

Results 405 comments of James Henry

fix(eslint-plugin-template): [click-events-have-key-events]: handle additional outputs

Thanks @sandikbarr!

no `no-unused-css` replacement

@JounQin Yes this is documented on the README that there is no equivalent yet and that PRs are welcome at any time from folks who use the rule. I'm happy...

fix(eslint-plugin-template): [i18n] handle `ng-template` properly

@rafaelss95 I think it might be revisiting this whole PR afresh once https://github.com/angular-eslint/angular-eslint/pull/968 has been merged

fix(eslint-plugin-template): [i18n] handle `ng-template` properly

Ok further update, that PR to alter the visitor keys was more fiddly than I thought, and the only way I could reliably not cause regressions in the existing i18n...

fix(eslint-plugin-template): [i18n] handle `ng-template` properly

I just tried it and applying the visitor keys update (with removing them again per the current state of the other PR) does cause all your commented out tests here...

fix(eslint-plugin-template): [i18n] handle `ng-template` properly

This led me to discover something very interesting, some of the cases we currently have are actually conceptually invalid: E.g. ``` convertAnnotatedSourceToFailureCase({ description: 'should fail if `i18n-*` attribute is missing...

fix(eslint-plugin-template): [i18n] handle `ng-template` properly

Surfaced a couple of issues, I merged it here: https://github.com/angular-eslint/angular-eslint/pull/969

feat(eslint-plugin-template): [no-duplicate-attributes] Add option to ignore properties

Thanks a lot @ssams - we just need to regenerate the docs now that the options have changed. You just need to run `yarn update-rule-docs` and commit the results

Templates: location information for data-binding is incorrect

Hi @jerone, this issue seems to be important to you, so please could you take a look into it? Please remember that this project receives no corporate backing or sponsorship...

docs: update outdated doc in favor of eslint-plugin-prettier v4.1.0

Thank you for flagging this up @JounQin. You refactored the section significantly so I wouldn't have been possible to merge this PR, but I have applied the changes and credited...