James Henry

Results 381 comments of James Henry
trafficstars

Sounds good to me @gSarciotto please feel free to submit a PR

I want to do a v3 release before we switch to v12 (to line up with Angular), so out of an abundance of caution let's class this as a breaking...

Thanks for digging deeper @gSarciotto - it seems to me then that actually it's just the lint message that needs improving. As you've said having just `root` goes against the...

@beyerleinf How are you invoking eslint? What does your root tsconfig.json look like (the one that the tsconfig.eslint.json is extending from)? As you can see in your logs you are...

Apologies folks, because of personal life pressures I have had to limit angular-eslint to v13 of Angular and v8 of ESLint, so this breaking change requirement will be bumped to...

@pmccloghrylaing sorry one of my suggestions made via the github UI was borked because of the single quote usage within the string, you'll need to fix up locally

Thanks @pmccloghrylaing this LGTM now, we just need to generate the rule docs then this can be merged. You just need to run `yarn update-rule-docs` and commit the result

This has ended up forming a much broader discussion around the i18n rule. Holding off on this for now until I hear back from @rafaelss95