James Glover

Results 57 comments of James Glover

Just search fo '@todo #2396' to find all purposes I've flagged with respect to this issue.

Picking up a few of these for #3091 to reduce the number of 'transition_to' methods I need to consider.

Surprisingly not done, a couple of bits still hanging around

@gauravruhela07 I'm not a maintainer, just an end-user reporting the issue, so am not able to assign issues.

Done a bit of probing into this one. It appears that this chart uses the `legacyRegularTime` section, which gets disabled when the feature flag `GENERIC_CHART_AXES` is enabled. Which suggests that...

Following a bit more analysis: `EventFlowViz.query_object` has a `granularity` of None when not present in the form object, which triggers the error message when handles by `get_sqla_query`. Adding: ``` if...

This PR fixes a similar issue on another chart by restoring the time section of the form in an ad-hoc manner: https://github.com/apache/superset/pull/23865