James Glover

Results 57 comments of James Glover

Given 'pending' typically indicates the plate is empty, and failed that the material in it either doesn't meet QC standards, or has somehow been contaminated, then a transition from pending...

# Additional background 1) Still have sample accessioning in two places - `Accessionable::Sample` which is the old way, does handle updates - `Accession::Sample` - Updated mechanism. Doesn't handle updates 2)...

I'll push up the 0.10 experimental branch once I've finished running down my current avenue of investigation.

Hmm, looks like the performance issues I refer to in https://github.com/sanger/sequencescape/pull/2149 might exist anyway. Briefly: - We patched in the ability to supply default_includes to automatically load associated records that...

Had another crack with json-api-resources 0.10.5 [Edit: ow 0.10.7]. *Almost* got there with a couple of monkey patches, but running into some major issues with relationships and STI. This branch...

Looked at https://github.com/stas/jsonapi.rb in context of unified Warehouse: 1) It is mostly just serialization, deserialization with a few helpers to handle parsing json api arguments 2) There doesn't seem to...

This is blocking Rails 6.1 release, so increases in importance

Looked into this a bit more, and it turns out there is an official fix underway, although it hasn't move much for a while: https://github.com/cerebris/jsonapi-resources/commits/sti_v0-10 There's a minor issue with...

We've also now got a new issue with some of the plate creation spec failing, but I think this is just due to the way readonly now works. (Ie. it...