Thomas Jakobi

Results 143 comments of Thomas Jakobi

I currently have no external media source available. This code tries to get the image size with img.onload, since the MODX way has issues with images larger than 800x600. With...

The issue is the onload requirement. An external media source has to retrieve the image different. If you are able to send me some code loading the image from an...

It is nice to have NULL available in datetime columns. This is allowed with NO_ZERO_DATE and NO_ZERO_IN_DATE and in strict mode. Only `0000-00-00` is not permitted. MODX has some datetime...

The issue with the migration script can be invalid existing values in the column, if I am right. In that case the database column definition can't be changed and an...

According to the docs https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_no_zero_date only `0000-00-00` is not permitted. I have not checked, whats going wrong if the column has no value in xPDO. Is it prepared as `0000-00-00`...

Maybe it is better to prepare an upgrade script that changes the value.

@Ruslan-Aleev There is no need to excuse. I understood your reaction at the end of January 2023.

This was discussed long before: https://github.com/modxcms/revolution/issues/12983#issuecomment-219218179

The setting was meant as a context setting in 2.x. I don't see any important change between [3.x](https://github.com/modxcms/revolution/blob/3.x/core/src/Revolution/modX.php#L2793-L2822) and [2.x](https://github.com/modxcms/revolution/blob/2.x/core/model/modx/modx.class.php#L2613-L2645) other than the setcookie version check.