Jake Wharton comments

Results 1657 comments of


                                            Jake Wharton

Improve wrapping logic of parameter lists

Here's my idea: a reverse `BufferedSource.peek()`. You `buffer()` a `CodeWriter` and write whatever you want to it but it goes to a `StringBuilder` not the real `Appendable`. Then, you inspect...

`jvmModifiers` doesn't return the Builder

It doesn't need to wait. ```kotlin @JvmName("jvmModifiers") @Deprecated(level = HIDDEN) fun jvmModifersOld(..) { .. } @JvmName("jvmModifiersNew") fun jvmModifers(..): Builder { .. } ```

`jvmModifiers` doesn't return the Builder

> Wouldn't it break implicit returns in Kotlin though? Yes it is source incompatible but literally (and not hyperbolically) no one is relying on this. It would have to be...

`jvmModifiers` doesn't return the Builder

It's allowed in bytecode, not source code.

Integrate kotlin ABI validator

May want to consider Metalava instead which makes an effort to _also_ ensure source compatibility and can work for targets other than the JVM.

Integrate kotlin ABI validator

android-ktx used it when it was on GitHub. It's just a project that poops out a jar like any other. Wire it up to a JavaExec and you're good to...

Smarter wrapping logic for long parameter lists

I certainly like the results. When do you emit a parameter spec with wrapping=False?

Smarter wrapping logic for long parameter lists

Ah, nice. I think I'd prefer if we flipped the boolean so that it wraps by default and we opt-out only in the lambda special case.

Implement PendingIntentCompat to enforce mutability flag.

You'll have to rewrite my commit to use `[email protected]` as the author email for the CLA check to pass. Or feel free to just squash my commit into yours–I don't...

Errant comma added between parameter lambda and parenthesis (when trailing lambda present)

Heh, I was upgrading from 0.41 😄