Jake Wharton

Results 1657 comments of Jake Wharton

We can do this during linking with a regular compiler plugin because linking sees all the IR, not just the compilation unit of the current module. https://kotlinlang.slack.com/archives/C7L3JB43G/p1698130170671859?thread_ts=1698116255.957259&cid=C7L3JB43G

https://github.com/cashapp/zipline/pull/1307

Yes. Although that doesn't cover Box. I think we should actually switch to a completely empty Modifier not just remove one. Then every test should snap back to the same...

So it sounds like views are just broken today (which is the point of the tests!). We can file a separate bug about them not clearing state.

Blocked by #900

Blocked only by DOM Box. Even if iOS Box has bugs we can still switch.

iOS Box is all good now. Blocked by DOM box only.

The impact of this will be quite large, because we effectively have to create tombstone widgets that somehow make it into the children collections but not the native UI tree.

Decisions: - Properties: do nothing. The callback can dedupe if it wants because it gets widget tag + property tag. - Children: I think we can just return null? Nodes...

A null widget should NOT notify the listener for missing properties or children!