Jake Wharton
Jake Wharton
Yeah I'm not sure I meant to write main thread there. That's what I get for filing a bug in a meeting. I think what I was trying to convey...
Seems like a great first step. Do you want feedback on the individual TODOs?
There's a TODO waiting for you to figure out and for me to steal!
On the Zipline? I think close closes, and something else probably returns a Deferred such that you can call withTimeout on await and then forcibly close. Maybe it's called shutdown?
> I'd expect the lack of `advanceTimeBy()` calls to fail the first `assertEquals()`. That is not how `runTest` works. If you do not take control of the time, delays are...
I've upgraded a bunch of open source and private projects (or, well, Renovate has) without incident. Can you make a minimally-reproducing project that I can try which exhibits the failure?
Delay testing remains the same as any other suspend function. You either need to take control of virtual time and assert against the effects of delayed code, measure virtual time...
What command are you using to build. That project fails to compile regardless of the Turbine version given the `assemble` task.
> Turbine will advance it for them, rendering their test for delays useless. That might be "correct" behavior and is due to runTest, but it is surprising behavior from my...
Going to close. Feel free to ping with an updated sample or more info if this is still a problem.