Jaifroid

Results 1244 comments of Jaifroid

> I think before we build new features, we should focus on the first part of your bug report, where "the more this process could be automated, the better". I...

It would be good to have some defined criteria for tasks that are best implemented in mwoffliner and/or in ZIM files, and tasks that are best left to the client...

Isn't there a proposal for an API in ZIMs that might handle this kind of transform? Currently the different readers handle dark mode by injecting CSS stylesheets. By using an...

@benoit74 I don't think it's quite so hard. A dev-contributor for the Kiwix JS browser extension contributed a dark mode stylesheet based on Vector (for Wikipedia ZIMs) which is now...

Despite what I wrote above, and in accordance with https://github.com/openzim/overview/issues/53, I agree that a pure CSS solution is better than using JS to switch between themes (if possible). So mwOffliner...

@Lucent That's a JS-based solution, whereas what we are being encouraged to support in readers is a pure CSS solution that looks like: ``` @media (prefers-color-scheme: light) { /* light-theme...

Problem is, it's really bad UX to have a toggle saying "Always use dark theme", but it doesn't work for the great majority of ZIMs. Of course you can have...

> The CSS media feature is only called `prefers-color-scheme` and calling it a preference to use if available seems like a reasonable approach. That's how it works in normal browsers...

@benoit74 I agree. All I'm asking for from mwOffliner is a way to signal that an mwOffliner ZIM has been made with explicit dark theme support.