Jaewook Ahn comments

Results 18 comments of


                                            Jaewook Ahn

Form add defaultValidateMessages.i18n language

Hello, I want to improve i18n for ko_KR. Can I do it?

Proptype warning when using StyleSheet on rightTextStyle

@danielforsberg @charleycesar To fix this problem, we can try to fix some ways: ## 1. Flatten style use `StyleSheet.flatten(styles.rightText)` ## 2. Change `propTypes` object in this checkbox component ``` static...

Can't create new credential

> @Jaewoook It also works normally in my environment. A new credential is created normally. Please check again Did you test with domain-admin permission? Let me know your test permission...

Change package manager from npm to yarn

If you want to reduce dependency hell, how about consider using **[pnpm](https://pnpm.io/ko/)**? It might helpful for reducing disk space and dependency complexity.

Let's provide code convention guide and apply rules to config files.

I found a PR #1306 that updates lint rules. How's it going?

Let's provide code convention guide and apply rules to config files.

I would like to suggest some conventions. ### Suggestion: Use consistent variable name Although the suggestion is ambiguous, I'm going to handle some case when naming variable. #### 1. element...

Let's provide code convention guide and apply rules to config files.

### Suggestion: import order I suggest applying the import/order rule. You can read more detail in following link. rule documentation: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/order.md

Let's provide code convention guide and apply rules to config files.

### Suggestion: lit-a11y rules The lit-a11y *(accessibility)* rules already applied in this project but there's so many lit-a11y errors in this project. Good accessibility makes better web experience for user....

Let's provide code convention guide and apply rules to config files.

### Suggestion: component method order (component structure) I think component can be separated as 4 part - variables / event handlers / renders / operation logics Each component has different...

Let's provide code convention guide and apply rules to config files.

> ### Suggestion: component method order (component structure) > I think component can be separated as 4 part - variables / event handlers / renders / operation logics > >...