Jacek Bukarewicz comments

Results 5 comments of


                                            Jacek Bukarewicz

cynara-test depends on random initialization of global instances

Thanks for finding these issues and for the patches. Yes, we need to get rid of direct std::string -> std::string dependencies. First patch looks good to me. The second patch...

cynara-test depends on random initialization of global instances

Ok, I understand. Right now I'm working on some urgent task, but I should finish soon and I'll be able to take care of it.

cynara-test depends on random initialization of global instances

I've pushed your first patch to gerrit: https://review.tizen.org/gerrit/#/c/41353 And also made some more changes: https://review.tizen.org/gerrit/#/c/41354

cynara-tests should not depend on en_US.UTF8

Yes, you are right - these are just ASCII strings. Creating UTF-8 locale object is an overkill. However, I suggest to use std::locale::classic() function instead of std::locale("C").

cynara-tests should not depend on en_US.UTF8

Fix pushed to: https://review.tizen.org/gerrit/#/c/41355