Jacob Alzén
Jacob Alzén
It would also be great if the "context canceled" error could be exposed somewhere (I could not find where it is created). This would allow me to check if it...
> > It would also be great if the "context canceled" error could be exposed somewhere (I could not find where it is created). This would allow me to check...
I'll try to review this as soon as I can. Wasm support in Fyne is nearing completion, so I'll want to try and get wormhole-gui running there as soon as...
I think it would be good if the changes weren't force-pushed every time. It makes it very hard to see changes between commits (if not impossible).
I think 64bit binaries would be a good addition and especially for arm64. It allows making use of newer instruction sets for better performance (see https://www.phoronix.com/scan.php?page=article&item=raspberrypi-32bit-64bit, not 100% related but...
PR #80 should solve this. We just need a fresh new release after it has landed :)
> I don't want to support os/arch'es that we don't actually have any users on or any way of testing against. I'm ok adding an "official" binary build for win/amd64...
> Lets not strip the binaries. The size improvement is fairly minimal and having DWARF by default is useful. Sounds sensible. I have backed out that change.
I also commented out arm64 for FreeBSD and Windows. I considered removing them entirely but I still think they make sense to add at some point.
Any chance to have this re-reviewed and merged sometime soon? It would be grata if we could get a new release afterwards as well :)