wormhole-william
wormhole-william copied to clipboard
psanford
Update build script to build for more architectures, fixes #77
This PR updates the build script to build arm64 binaires for ~~FreeBSD~~, macOS and ~~Windows~~. It also makes sure to add amd64 binaries to Windows. Lastly, the release action got updated to use the new Go 1.18.3 version for register based calling convention on arm64 as well as some security fixes.
Fixes #77
~~Release builds now also strip the DWARF data from binaries. This means that release binaries go from being 10MB to being 7MB instead.~~
Lets not strip the binaries. The size improvement is fairly minimal and having DWARF by default is useful.
I don't want to support os/arch'es that we don't actually have any users on or any way of testing against. I'm ok adding an "official" binary build for win/amd64 and darwin/arm64.
I don't want to support os/arch'es that we don't actually have any users on or any way of testing against. I'm ok adding an "official" binary build for win/amd64 and darwin/arm64.
I have a Raspberry Pi 4 that I can run FreeBSD arm64 on. Would that suffice as reason enough to add that binary?
If we don't have any users on the platforms it likely is because we didn't have binaries for them. I'd honestly be in favour of keeping Windows arm64 for that reason but I can certainly remove it for you.
Lets not strip the binaries. The size improvement is fairly minimal and having DWARF by default is useful.
Sounds sensible. I have backed out that change.
I also commented out arm64 for FreeBSD and Windows. I considered removing them entirely but I still think they make sense to add at some point.
Any chance to have this re-reviewed and merged sometime soon? It would be grata if we could get a new release afterwards as well :)
It certainly would be nice to get this merged and then have a new release out. The latest release was almost a year ago at this point
I have now updated the Go version to be 1.19.4 for the release binaries. Would you mind re-reviewing @psanford?