J. George comments

Results 333 comments of


                                            J. George

Add python 3.12 to officially supported versions and test it in CI

@janosh : see https://github.com/materialsproject/pymatgen/issues/3775

Add python 3.12 to officially supported versions and test it in CI

@janosh could you try this solution for now? https://github.com/python/cpython/issues/105524#issuecomment-1610750842

Add python 3.12 to officially supported versions and test it in CI

@janosh We had issues in #3439 that the Userdict solved.

Add python 3.12 to officially supported versions and test it in CI

I can try again in the next days. Need to fix other stuff as well. Sorry that this functionality here is such a pain.

Add python 3.12 to officially supported versions and test it in CI

> the thing making this hard to debug is that i can't repro the issue locally. even on 3.12, everything works for me on macOS. don't understand why this would...

Add python 3.12 to officially supported versions and test it in CI

@janosh tests are passing locally now for py 3.12. You might want to check the tmp_dir change. The rest should hopefully be fine now.

Add python 3.12 to officially supported versions and test it in CI

3.9 and 3.12 tests are passing. 3.11 does not run.

Changing MP Input Sets

Just from the times when I ran such computations by hand: I have always done a loose and then strict calculation. I therefore think it is a good idea. I...

Re-enable tests that are skipped in CI

@ml-evs Should one also dis-enable the corresponding featurizers as well for now? See https://github.com/hackingmaterials/matminer/issues/915#issuecomment-1933160620

Missing compatibility with pandas v2

Any opinions? @ardunn @tschaume ? I guess it could break subsequent code. I would love to keep on using matminer but in it's current state that's probably hard to do.