matminer icon indicating copy to clipboard operation
matminer copied to clipboard
verified publisher icon hackingmaterials

Re-enable tests that are skipped in CI

Open ml-evs opened this issue 1 year ago • 2 comments

#922 disables some tests as they do not work with the latest numpy/pandas combo. This may be because the test code itself is broken, or bad numpy/pandas calls are being made in the featurizer or an upstream dep.

ml-evs avatar Feb 07 '24 23:02 ml-evs

@ml-evs Should one also dis-enable the corresponding featurizers as well for now? See https://github.com/hackingmaterials/matminer/issues/915#issuecomment-1933160620

JaGeo avatar Feb 08 '24 06:02 JaGeo

@ml-evs Should one also dis-enable the corresponding featurizers as well for now? See https://github.com/hackingmaterials/matminer/issues/915#issuecomment-1933160620

Yeah I think that's next on the list, I just want to verify that it's not the test cases themselves that are the problem first

ml-evs avatar Feb 08 '24 09:02 ml-evs

Closed by #925

ml-evs avatar Mar 26 '24 12:03 ml-evs