Jonathan Valldejuli

Results 6 comments of Jonathan Valldejuli

Setting up pipeline for use in both app and notification service extension

For anybody wondering, this has been working well so far!

Image download requests not deduplicated

Hi, looks like your issue is that you are creating a fresh `ImagePipeline` for each request. You need to configure the `ImagePipeline.shared` singleton instance and stop passing a custom image...

Fix bug where requests with processors would not check disk cache for original image data

To fix https://github.com/kean/Nuke/issues/837. Please let me know if you'd like me to take a different approach. Thank you!

Fix bug where requests with processors would not check disk cache for original image data

Closing because I think I found a better solution.

Fix bug where requests with processors would not check disk cache for original image data

Reopening for now, realized the other approach has some drawbacks.

Fix bug where requests with processors would not check disk cache for original image data

The change that I've actually started using in my own app is to allow the pipeline delegate to provide unique custom keys for both the memory and disk caches. The...