James Skimming

Results 24 comments of James Skimming

It's a great idea. Maybe as an extension method to `IProxyGenerator` so something like this: ```csharp IEquatable sample = EqualityComparer.Default; // sample name stolen from Rx, if/when implementing spend more...

What happens if you use [Castle.Core.AsyncInterceptor v2](https://www.nuget.org/packages/Castle.Core.AsyncInterceptor/2.0.0)?

@htzhang2 Can you provide a complete example to reproduce? There is no `IMethodInterceptor` in Castle.Core.AsyncInterceptor.

@hivanov The discrepancy is because this library does not consider `ValueTask` and `ValueTask` (it predates them by a few years) and it determines whether a method is asynchronous based on...

@brunoblank Thanks for this. > Looking at the code-coverage, Adding a tests for InvocationBase will bring coverage back to around 100% Yes, it would be good to get the coverage...

@alex-training thanks for joining in. It's great to get further input. I'll start weighing in soon. I've never quite known whether this library is receiving much usage, the engagement of...

@brunoblank I've just had a look and made a few minor changes. I've restored the intent of the `WhenExceptionInterceptingAnAsynchronousMethodThatThrowsASynchronousException` test. I've added a comment stating the intent of the test,...

@brunoblank Thanks for that last commit. I'm afraid my weekend was busier than expected and I've not been able to devote much time to this. I will endeavour to review...

@brunoblank rather hectic. We have a new product going live on Tuesday and I've not been able to devote any free time to this in recent weeks. I hope to...