Jackson Mills

Results 73 comments of Jackson Mills

Question answered here: https://github.com/XRPLF/XRPL-Standards/discussions/46#discussioncomment-2548482 Will follow up once the feature has been added to [Clio](https://github.com/cjcobb23/clio) :)

Here's a PR for the same task in xrpl-js which might be useful as a reference - https://github.com/XRPLF/xrpl.js/pull/1799

Here's the script I used to test the code: ``` import asyncio from xrpl.asyncio.account.transaction_history import get_account_transactions from xrpl.models.requests.account_tx import AccountTx from xrpl.asyncio.clients.async_websocket_client import AsyncWebsocketClient async def test_marker(): client = AsyncWebsocketClient("wss://s.altnet.rippletest.net:51233")...

> Would a unit test suffice to make sure it is passed through to the underlying methods? @ckniffen I'm not really sure how to set up a unit test that...

Separately, @LimpidCrypto with this implementation I wrote, the function does NOT return the marker, which is a bit of a usability issue. (Because it doesn't allow for continuous pagination). Directly...

> If the user works with `get_account_transactions`, the user doesn‘t have a quick way to check wether all transactions for that account were received. To check if a `marker` has...

(Still need to export these new functions, which I've been struggling to do because it seems like Sphinx isn't working - so the pre-commit hook for Sphinx is blocking changes....

@mvadari pointed out that this `with_marker` variant was basically the same thing as calling `AccountTx` directly, so I just added to the docs pointing out that if you need the...

(This PR still is also required to fix the Sphinx dependency issues which were preventing merges previously - updated the PR title to reflect that)

I think xrpl.js does have the field here: https://github.com/XRPLF/xrpl.js/blob/aff6988f098ecc033a0cfa7974101f91de5cf948/packages/xrpl/src/models/transactions/common.ts#L156 The xrpl-py missing this value seems like an oversight. Started fixing it but didn't finish today.