xrpl-py icon indicating copy to clipboard operation
xrpl-py copied to clipboard

Published 20 hours ago • verified publisher icon XRPLF

Add common field `ticket_sequence` to `Transaction`

Open LimpidCrypto opened this issue 3 years ago • 2 comments
trafficstars

The field ticket_sequence is missing as a common field in the Transaction object. It is needed to specify which ticket to be "replaced" with the transaction. Since no one complained so far, I guess it's not that urgent.

LimpidCrypto avatar Jul 01 '22 23:07 LimpidCrypto

I just saw the xrpl.js also does not has the field. Is that intended? Why is that?

LimpidCrypto avatar Jul 03 '22 11:07 LimpidCrypto

I think xrpl.js does have the field here: https://github.com/XRPLF/xrpl.js/blob/aff6988f098ecc033a0cfa7974101f91de5cf948/packages/xrpl/src/models/transactions/common.ts#L156

The xrpl-py missing this value seems like an oversight. Started fixing it but didn't finish today.

JST5000 avatar Jul 05 '22 23:07 JST5000

Resolved by #428

LimpidCrypto avatar Sep 02 '22 22:09 LimpidCrypto