Computer Network Investigation
Computer Network Investigation
> Can you also elaborate the reasoning for moving this towards target-yara and removing the functionality from target-query? On the one hand I can understand that it's nice to be...
~Is YARA-X integration welcome in this PR, or should we wait until this has been merged in `main`?~ We will push this to a separate PR.
It seems like that was all feedback, apologies for the delay @Schamper. Is this good to go now?
```python + for args, kwargs in getattr(YaraPlugin.yara, "__args__", []): + parser.add_argument(*args, **kwargs) ``` That's actually a very neat solution, thanks!
We've taken the liberty to add your patch as a commit to the PR :smile:
That seems to have done the trick :wink:
Thanks for the review @Schamper. We've implemented the review feedback in https://github.com/fox-it/dissect.target/pull/711/commits/fde58ae91aaeeb1adba73c32e27d939cadee05ba. Test coverage should now be better. See the commit message for the other stuff we changed.
Is this PR good to go? :)
> I've made a few changes, let me know if those work for you @JSCU-CNI. That looks like a neat solution, thanks. I guess we can update the namespaces to...
That should fix the tests.