Josh Pinkney

Results 63 comments of Josh Pinkney

Also for some reason if you auto complete on a different line after true with a few spaces indented it tries to auto complete for values true/false

Thanks! That code will be very helpful! I don't _think_ in the second screenshot it would be valid yaml so yeah its probably something that we could check in `getPropertyCompletions`

Out of curiosity which schema are you using for validation? Or do you have the vscode-ansible extension installed?

Just one more thing, was the file created under a folder name tasks? I'm only wondering because we use [schema store](http://schemastore.org/json/) to match well-known file types to schemas. My suspicion...

I like the idea of switching to either `minimatch` or `micromatch`. I found a github gist of the [differences](https://gist.github.com/jonschlinkert/96212e11d128fc659d12) and it seems that micromatch is slightly better. For reference the...

Ideally we can get the PR merged on vscode-json-languageservice and then just make sure our code works with it. > I can start fixing this by replacing JSONSchemaService with our...

I _think_ we might still might have to adapt https://github.com/redhat-developer/yaml-language-server/blob/master/src/languageservice/parser/isKubernetes.ts#L15 because it looks like it still uses the old file pattern association

We autodetect schemas from http://schemastore.org/json/ based off of filename but other then that there isn't a way to decide the schema based off of context yet. I believe @andxu was...

This LS has all the same features as that one. When the creator of that one was closing his vscode extension he wanted to make sure that we supported all...

Currently hasn't been worked on. It is not a hard thing to add I just haven't had the time.