JPalakapillyKWH
JPalakapillyKWH
@cwhanse The spatial resolution varies since googlemaps (as I've gathered) uses a patchwork of different signals but is generally at least 90m. The code will capture the near-field horizon to...
It is designed for far-field.
@cwhanse and @wholmgren I made a lot of the code restructuring changes y'all suggested. Many functions were moved to tools.py. I am currently working on making the code more numpy-friendly....
@mikofski You are correct about ground station data already incorporating far field losses. This is designed for satellite irradiance data (PSM, TWC etc.) @adriesse I took many of your suggestions...
> Awesome! Would you consider adding a advisory note in the docstring with this warning on usage? Which docstring do you mean?
There seem to be a lot of timeout issues in the tests. Anybody have any insight? I pass `pytest pvlib` locally.
@adriesse Fair point. I can include just horizon.py and test_horizon.py in this PR.
> @JPalakapillyKWH Beware though, that my opinion is only one; there may be others... I tend to agree that this code should be split into multiple PRs. Hopefully this will...
> Working my way through the docstrings and code. I am a little confused about the purpose of the "sample" functions - if a grid is being supplied as input,...
@adriesse You are right in that there is not a whole lot of overlap. Much of the code in this PR is taken from the geometry used in viewshed analysis....