Jonathan G Rennison

I'll see what I can do on that. It won't do anything about #9876 though. That is an unrelated issue.

Procedure calls (variable 0x7E, DeterministicSpriteGroupAdjust::subroutine) aren't handled. If a deterministic group adjust references a procedure, DSGA_OP_STOP operations (but not any form of callback result) recursively reachable through the procedure group...

This looks fine to me, I've got no objections.

> @michicc Can you please have a look at the implications for PBS. Why do TryReserveSafeTrack/FollowTrainReservation/FreeTrainTrackReservation use `GetRailTypeInfo(v->railtype)->compatible_railtypes`? I'm not really michicc, but I've looked into this previously... The PBS...

> The you're sure right that A->B does not imply B->A with the classical example of standard RAIL (A) and electrified rail ELRL (B) RAIL and ELRL are mutually compatible...

I've got a commit for the modifier key race issue here: https://github.com/JGRennison/OpenTTD-patches/commit/59daa573b5dc335e9adcdc365bd65fabcb8f145f In theory incorrect behaviour might be able to occur if the control key state was changed at the...

> Too slow :P I went for a slightly different approach to the problem, but looking back I am not sure I like mine. I think yours is easier .....

Having a train in motion, even for one tick, with no reservation in these circumstances sounds highly unsafe. If the train happens to be at a tile edge when the...

@2TallTyler In River_FoundEndNode you are interleaving calls to MakeRiver along the tiles found by the A-star path with calls to RiverMakeWider which modify the landscape. This is likely to result...

Teleporting vehicles would be excessively fiddly when it comes to articulated vehicles, and road layouts including things like junctions, corners, tunnel/bridges, etc. If a road vehicle is already part way...