Jordan Frankfurt
Jordan Frankfurt
concept ack I'll gladly review this PR. You may want to look at the wallet connect connectors, as it sounds like part of the new functionality is similar. Q: What...
I hate this bug and I'm so excited to have someone fixing it. tysm
heads up @Jdecristi the only thing stopping this from merging is the lint issue
https://github.com/Jdecristi/uniswap-interface/pull/1
looks like you've got a failing unit test: ``` FAIL src/components/AccountDrawer/MiniPortfolio/Activity/utils.test.ts ● createGroups › should sort and group activities based on status and time expect(received).toContainEqual(expected) // deep equality Expected value:...
close/reopen to fix action checks
@Jdecristi I'd try merging upstream's main into your branch to see if that fixes your CI problems.
Thank god CI is finally passing. Sorry about that.
Since it's a single character copy change you don't need to worry about it. Technically you could probably address that with a unit test that asserts text content or does...
I am not familiar with the pattern you're describing. I would always expect the address to remain the same as networks change. (Since the key pair is valid on all...