interface
interface copied to clipboard
feat: allow WETH when adding liquidity to an existing LP position
fixes: #3705
Description
Allow users to add liquidity using WETH when adding liquidity to an existsing LP position
Screen capture
https://github.com/Uniswap/interface/assets/89173284/eb60c35f-5502-4cde-b9c1-9da6cd8cf44e
Test plan
Reproducing the error
- navigate to app.uniswap.org/pools
- Navigate to a pool using ETH or other native token
- Make sure the toggle works and can still increase liquidity with WETH
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
interface | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 4, 2023 0:34am |
Could you please make the toggle styling consistent with the one the "Selected range" row above? It'll reduce visual clutter and should help with overflow
Codecov Report
Merging #7282 (4bea0fd) into main (2e618fb) will decrease coverage by
0.10%
. The diff coverage is0.00%
.
:exclamation: Current head 4bea0fd differs from pull request most recent head 452616c. Consider uploading reports for the commit 452616c to get more accurate results
Flag | Coverage Δ | |
---|---|---|
cloud-tests | ? |
|
unit-tests | 43.10% <0.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
I hate this bug and I'm so excited to have someone fixing it. tysm
@just-toby @JFrankfurt @infredible Sorry for the late response. Just started a new job, and things are hectic. I fixed the issues you brought up.
- Code standards
- Styling to match other toggles
- Rebased and conflicts resloved
The video of me actually adding liquidity is in the Screen Capture section at the top
Cheers!
heads up @Jdecristi the only thing stopping this from merging is the lint issue
https://github.com/Jdecristi/uniswap-interface/pull/1
@JFrankfurt fixed!
looks like you've got a failing unit test:
FAIL src/components/AccountDrawer/MiniPortfolio/Activity/utils.test.ts
● createGroups › should sort and group activities based on status and time
expect(received).toContainEqual(expected) // deep equality
Expected value: ObjectContaining {"title": "Today", "transactions": ArrayContaining [ObjectContaining {"status": "CONFIRMED", "timestamp": Any<Number>}]}
Received array: [{"title": "Pending", "transactions": [{"status": "PENDING", "timestamp": 1700000000}]}, {"title": "This week", "transactions": [{"status": "CONFIRMED", "timestamp": 1697068759.077}]}, {"title": "2022", "transactions": [{"status": "CONFIRMED", "timestamp": 1650000000}]}]
31 | )
32 |
> 33 | expect(result).toContainEqual(
| ^
34 | expect.objectContaining({
35 | title: 'Today',
36 | transactions: expect.arrayContaining([
at Object.<anonymous> (src/components/AccountDrawer/MiniPortfolio/Activity/utils.test.ts:33:20)
check the action report at the bottom of the pr
close/reopen to fix action checks
@Jdecristi I'd try merging upstream's main into your branch to see if that fixes your CI problems.
Someone is attempting to deploy a commit to the Uniswap Team on Vercel.
A member of the Team first needs to authorize it.
@JFrankfurt I just ran a rebase on to updated main hope this helps.
Also sorry for the infrequent responses have little time now new job and learning solidity
Thank god CI is finally passing. Sorry about that.