interface icon indicating copy to clipboard operation
interface copied to clipboard

feat: allow WETH when adding liquidity to an existing LP position

Open Jdecristi opened this issue 1 year ago • 14 comments

fixes: #3705

Description

Allow users to add liquidity using WETH when adding liquidity to an existsing LP position

Screen capture

https://github.com/Uniswap/interface/assets/89173284/eb60c35f-5502-4cde-b9c1-9da6cd8cf44e

Test plan

Reproducing the error

  1. navigate to app.uniswap.org/pools
  2. Navigate to a pool using ETH or other native token
  3. Make sure the toggle works and can still increase liquidity with WETH

Jdecristi avatar Sep 08 '23 05:09 Jdecristi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2023 0:34am

vercel[bot] avatar Sep 08 '23 05:09 vercel[bot]

Could you please make the toggle styling consistent with the one the "Selected range" row above? It'll reduce visual clutter and should help with overflow

image

infredible avatar Oct 04 '23 22:10 infredible

Codecov Report

Merging #7282 (4bea0fd) into main (2e618fb) will decrease coverage by 0.10%. The diff coverage is 0.00%.

:exclamation: Current head 4bea0fd differs from pull request most recent head 452616c. Consider uploading reports for the commit 452616c to get more accurate results

Flag Coverage Δ
cloud-tests ?
unit-tests 43.10% <0.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Oct 05 '23 07:10 codecov[bot]

I hate this bug and I'm so excited to have someone fixing it. tysm

JFrankfurt avatar Oct 06 '23 16:10 JFrankfurt

@just-toby @JFrankfurt @infredible Sorry for the late response. Just started a new job, and things are hectic. I fixed the issues you brought up.

  1. Code standards
  2. Styling to match other toggles
  3. Rebased and conflicts resloved

The video of me actually adding liquidity is in the Screen Capture section at the top

Cheers!

Jdecristi avatar Oct 08 '23 00:10 Jdecristi

heads up @Jdecristi the only thing stopping this from merging is the lint issue

JFrankfurt avatar Oct 11 '23 22:10 JFrankfurt

https://github.com/Jdecristi/uniswap-interface/pull/1

JFrankfurt avatar Oct 11 '23 22:10 JFrankfurt

@JFrankfurt fixed!

Jdecristi avatar Oct 11 '23 23:10 Jdecristi

looks like you've got a failing unit test:

FAIL src/components/AccountDrawer/MiniPortfolio/Activity/utils.test.ts
  ● createGroups › should sort and group activities based on status and time

    expect(received).toContainEqual(expected) // deep equality

    Expected value: ObjectContaining {"title": "Today", "transactions": ArrayContaining [ObjectContaining {"status": "CONFIRMED", "timestamp": Any<Number>}]}
    Received array: [{"title": "Pending", "transactions": [{"status": "PENDING", "timestamp": 1700000000}]}, {"title": "This week", "transactions": [{"status": "CONFIRMED", "timestamp": 1697068759.077}]}, {"title": "2022", "transactions": [{"status": "CONFIRMED", "timestamp": 1650000000}]}]

      31 |     )
      32 |
    > 33 |     expect(result).toContainEqual(
         |                    ^
      34 |       expect.objectContaining({
      35 |         title: 'Today',
      36 |         transactions: expect.arrayContaining([

      at Object.<anonymous> (src/components/AccountDrawer/MiniPortfolio/Activity/utils.test.ts:33:20)

check the action report at the bottom of the pr

JFrankfurt avatar Oct 13 '23 15:10 JFrankfurt

close/reopen to fix action checks

JFrankfurt avatar Oct 19 '23 17:10 JFrankfurt

@Jdecristi I'd try merging upstream's main into your branch to see if that fixes your CI problems.

JFrankfurt avatar Nov 01 '23 16:11 JFrankfurt

Someone is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 02 '23 03:11 vercel[bot]

@JFrankfurt I just ran a rebase on to updated main hope this helps.

Also sorry for the infrequent responses have little time now new job and learning solidity

Jdecristi avatar Nov 02 '23 03:11 Jdecristi

Thank god CI is finally passing. Sorry about that.

JFrankfurt avatar Nov 03 '23 16:11 JFrankfurt