JF

Results 209 comments of JF

This kind of issue is not easy to diagnose as there are a lot of moving parts. The issue could be caused by the PineTime, InfiniTime, the companion app, the...

I'm not sure I remember how this specific color was chosen, to be honest. We used to have maintainers who took care of the UI (themes, colors, layout,..) but they...

I'm OK with this change, thanks @ajira86 for your contribution! I'm not sure why the CI is red for build-firmware, build-simulator and test-clang-tidy for such a small change. But since...

When I checkout the @ajira86 's branch, it's checked out as a detached head, so I'm not sure I can push it after I fix the conflict.

@FintasticMan Thanks! :+1 I'll need to learn this feature from Github! The action build-firmware failed because of the "/" in the branch name so that's not an issue. I'll merge...

> Actually the same problem exists with TouchHandler. Should we clear the tap state there too? Or do we define calling its methods as UB when the touch panel is...

I've just measured the power usage with BLE disabled : - 1.14 for reference in sleep mode : 413µA - `main` in sleep mode : 400µA - `main` AOD :...

> I'm happy to do a PlantUML (I've used it before actually), I guess I'll queue up a new PR when that's done? Yeah sure, just open a new PR...

Thank you very much for creating and maintaining this PR (in InfiniTime, InfiniSim AND Gadgetbridge!) @vkareh ! Could you confirm that these change do not break the compatibility between InfiniTime...

I can't remember why we specified -O3 specifically for that target. The history is not clear about that, it was changed from -Os back and forth to -O3 multiple times...