J.D. Grimes

Results 172 comments of J.D. Grimes

Probably we should also introduce one to update a points log, as I don't think that we have that either. I think we have one to delete a points log,...

Note that using `WP_Query` with `id__in` has some unexpected behavior: it will only return the log if it is from the current site on the network. This is because `WP_Query`...

However, you can pass `blog_id` as `null`, and thus bypass the default behavior.

#546 added the `id` parameter, which is more natural than `id__in`, although it is still important to pass `blog_id` as `null`.

> maybe without even needing to modify our registries' design. It doesn't seem that that will be the case. I just did some experimenting with this, and it doesn't seem...

Possibly we wouldn't have to actually modify the registries that we regularly use at all. Instead we could just make it so that special registries are used when we are...

A problem here in passing objects into the class registries for anything other than mocks is that sometimes the classes are requested to be constructed with particular args. But there...

Apparently it actually [is possible to mock classes in PHPUnit](http://stackoverflow.com/a/13390001/1924128) after all. So maybe we should try that again.

I think that part of the issue is, we can mock the class, but it still has to be configured. That is, the return values of the mocked methods have...

We have begun to use PHPUnit mock objects a lot more. However, we still haven't come up with a good way to use this pattern for non-persistent class registries. So...