J.D. Grimes
J.D. Grimes
An added dimension comes with network deactivation, because we need to check dependents on all sites, in addition to network-active ones. That isn't our concern at the moment though.
>Again thought, this shouldn't really affect updates directly, since things should already be required to be active at the time of the update anyway. Although this will generally be true,...
It [looks like the page isn't loading fully](https://travis-ci.org/WordPoints/wordpoints/jobs/320696350#L1065-L1080): ``` Scenario: * I am on page "/wp-login.php?redirect_to=wp-admin%2Fadmin.php%3Fpage%3Dwordpoints_points_hooks" [GET] http://127.0.0.1:8080/wp-login.php?redirect_to=wp-admin%2Fadmin.php%3Fpage%3Dwordpoints_points_hooks [Sat Dec 23 16:27:14 2017] 127.0.0.1:42506 [200]: /wp-login.php?redirect_to=wp-admin%2Fadmin.php%3Fpage%3Dwordpoints_points_hooks [Sat Dec 23 16:27:14...
I ran this again with similar results: ``` Scenario: * I am on page "/wp-login.php?redirect_to=wp-admin%2Fadmin.php%3Fpage%3Dwordpoints_points_hooks" [GET] http://127.0.0.1:8080/wp-login.php?redirect_to=wp-admin%2Fadmin.php%3Fpage%3Dwordpoints_points_hooks [Sat Dec 23 20:56:22 2017] 127.0.0.1:40628 [200]: /wp-login.php?redirect_to=wp-admin%2Fadmin.php%3Fpage%3Dwordpoints_points_hooks [Sat Dec 23 20:56:22 2017]...
I did find this [SO question related to the Invalid Request message](https://stackoverflow.com/q/29141240/1924128), but nothing there was really helpful. A suggestion that it was a bug fixed in PHP 7.2 didn't...
I have tried to reproduce this locally, with no luck.
This appears to possibly be related to the latest build update, see https://github.com/travis-ci/travis-ci/issues/8913. I guess we should try reverting to the old infrastructure and see if that fixed the issue.
Yep, this does appear to [work on the previous build version](https://travis-ci.org/WordPoints/wordpoints/builds/322355206), although we do have some test failures for some reason (possibly related to recent code changes).
The PhantomJS version does appear to have changed. On the [new image](https://travis-ci.org/WordPoints/wordpoints/builds/320696349#L341-L342): ``` PhantomJS version 2.1.1 ``` On the [old image](https://travis-ci.org/WordPoints/wordpoints/builds/322555100#L734): ``` PhantomJS/2.0.0 ``` I wonder if that is related.
It does indeed appear to be [possible to work around this](https://travis-ci.org/WordPoints/wordpoints/builds/322686665) by [installing PhantomJS 1.9.8](https://gist.github.com/julionc/7476620#file-install_phantomjs-sh-L13-L32). When [installed but not aliased](https://travis-ci.org/WordPoints/wordpoints/builds/322695416), the build still stalls.