J0WI

Results 350 comments of J0WI

What about `disk_free_space` and `disk_free_space` to replace `df`? https://github.com/nextcloud/serverinfo/blob/9dfa5ddb2aabb1772b37ced95f8ca991e20f6c7f/lib/OperatingSystems/DefaultOs.php#L209

`executeCommand()` and `readContent()` are just wrappers and still require `shell_exec()`: https://github.com/nextcloud/serverinfo/blob/3230b6e58f6fe46e208e1ed54f26e5beec060f0d/lib/OperatingSystems/DefaultOs.php#L217-L231

The issue is to avoid `shell_exec` completely to avoid issues on systems where the function is disabled. https://github.com/nextcloud/serverinfo/issues/169#issuecomment-631762215 is the only remaining use of `executeCommand()`.

`shell_exec('cat ...')` can also be replaced by `readContent('...')`

This might be fixed in https://github.com/nextcloud/serverinfo/pull/281

> As far as I know there is no other way to get the data of the API without creating an admin user. See workaround in https://github.com/nextcloud/serverinfo/issues/100#issuecomment-412333522

The performance is already pretty bad on large instances. Most likely due share statistics but better safe than sorry.

> It also takes care of displaying videos on public pages, so as long as the viewer doesn't take care of that we should make it possible to have both...

It seems that all related issues have been fixed. @mkuzmin what is the current state of the extension?

I'd not trust `mtime` too much. It's safer to check for active symlinks in `/etc/letsencrypt/live`. You never know from where they have been moved, restored etc. Also even expired certs...