Ivan Carvalho

Results 185 comments of Ivan Carvalho

@HuangJunye, I am meeting with Matthew today to define the deliverables

> ``` > def select_llm_model(): > model_type = st.selectbox( > "Select the model provider you want to use:", > ["OpenAI", "Gemini", "Self-Hosted"], > index=0 > ) > return model_type >...

I think the code is looking better now, the compiler is complaining about some unused variables + trait missing for Python but overall this was a big improvement! Thanks

> I have modified the functions in `minimum_cycle_basis.rs` so that they are able to take `weight_fn` that returns `Result`. By this, I guess we can deal with more general weights...

I will expand this answer but: After #1235 is merged, I think we’ll be able to spawn VF2 in a separate thread and then have the main thread check Python...

Indeed, `node_attrs` and `edge_attrs` are necessary to get a more useful output. For example: ```python import rustworkx G = rustworkx.PyGraph() a = G.add_node("A") b = G.add_node("B") c = G.add_node("C") G.add_edges_from([(a,...

I think the challenge for this is similar to what I pointed out at https://github.com/Qiskit/rustworkx/issues/1081#issuecomment-1934107223 Currently, we don't have a way to convert a [SciPy sparse array](https://docs.scipy.org/doc/scipy/tutorial/sparse.html) into Rust. We'll...

@Krishn1412 the solution is along those lines. As long as scipy remains an optional dependency, it’s fine. But I think the methods should take a scipy sparse array. With that...

I think `unsafe` as a last-resource is OK and with Matthew's +1 we can merge it as is. However, before we do that: can you try using a PyFunction similar...

As you can see `PyGraph.remove_edge` was not designed with multigraphs in mind. The functionality you want though, already exists with [`PyGraph.remove_edge_from_index`](https://www.rustworkx.org/apiref/rustworkx.PyGraph.remove_edge_from_index.html#rustworkx.PyGraph.remove_edge_from_index). If you want to delete a specific edge between...