Ivan Carvalho

Results 185 comments of Ivan Carvalho

> > they are the most likely to forget to update those > > Would running MyPy on your tests help? That way if they forget they get an explicit...

> From the upper directory tests now fail this way: > > ``` > ==================================================================================== test session starts ===================================================================================== > platform freebsd13 -- Python 3.9.13, pytest-7.1.2, pluggy-1.0.0 -- /usr/local/bin/python3.9 >...

Thanks for attempting to port `rustworkx` to FreeBSD. FreeBSD is not officially supported by us (we do not test it in our CI), but I am sure FreeBSD users will...

Also, strongly advise you to port from our releases (https://github.com/Qiskit/rustworkx/releases) instead of the main branch

I will argue that retworkx is currently suitable for shortest paths, maximum weight matching, and subgraph isomorphism on the algortihmic side; and manipulation of the dynamic DAGs on the graph...

> What about `google_matrix`, `hub_matrix`, and `authority_matrix` looking at those it looks like they're used internally by the functions you listed but also exposed as public functions in networkx. Do...

I need to verify the newly added functions to `PyGraph` and `PyDiGraph`, and also check if there were updates to function signaturs. But this PR is ready to review

> I'm generally in favour of libraries providing type hints if at all possible - it's hopefully not too much work, and lets downstream users make the choice over whether...

I rewrote the custom return types annotations from zero. Because they are generated from the same Rust macro, I created an abstract class representing each macro and inherited from them....

> Is a retry actually sufficient for this? The issue we're hitting periodically in CI is python's tempfile usage on the macOS CI nodes isn't creating the file or macOS...