IvanCraft623 comments

Results 54 comments of


                                            IvanCraft623

Add onEntityCollide function when entity are above a block

This does not really check if there is a collision so if there is a slab between the magma block and the player, the player will be burned.

[Suggestion] Add support for blockentities

yeah, i'll take a look someday

Fix floating point issue

I'm not seeing the issue, please mention reproduction steps

Implemented a proper way to handle items cooldown

pocketmine in server-side is applying the cooldown to the items with the same `stateId`, while through `PlayerStartItemCooldownPacket` the cooldown is applied to all items with the same name. This means...

Implemented a proper way to handle items cooldown

Also i'm not sure if vanilla sends `PlayerStartItemCooldownPacket` to tell clients about cooldown.

fix(Explosion): don't apply motion if the event's cancelled

vanilla also applies motion even if the damage has been cancelled

fix(Explosion): don't apply motion if the event's cancelled

> But isn't the goal of pocketmine to customise the game by changing certain behaviours? Yes, but specifically this customization should not be done through EntityDamageEvent.

fix(Explosion): don't apply motion if the event's cancelled

`EntityDamageByEntityEvent` has a `knockback` property that is not being used for explosions, we could standardize the use of a knockback property in `EntityDamageEvent` that defaults to zero and take use...

Fixed anvil placing rotation.

Pretty sure this change is a bug fault of their migration from old `direction` to `minecraft:cardinal_direction` block state

Fixed anvil placing rotation.

Reported: https://bugs.mojang.com/browse/MCPE-183397