IvanCraft623

Results 30 comments of IvanCraft623

> This sound is missing from all eating events, and should more correctly be played in `Player->consumeHeldItem()`. In the way you suggest, only if the `Consumable` is an item will...

It is better to unify both events, they are practically the same.

I think `sendToast()` + docblock or `sendToastPopup()` are ok, would be descriptive and simple.

I will take up this PR when I have time.

> I think an event must be written for this feature. There is PlayerEntityInteractEvent

> The PR looks functionally OK. > > The thing that's giving me pause is that the mode of operation here is inconsistent with every other method of item interaction....

The following changes have been made: - Logic for renaming has been moved to `NameableTrait`, renameable entities should use it and implement `Nameable` - Implemented API for Interactive Tags (interaction...

> Where did you get this from? The duration is always set to 30 seconds. Did you play-tested it? https://user-images.githubusercontent.com/57236932/189500543-05352acd-8e98-4e6e-a80f-4a470358e863.mp4

> Is there anything in specific that is incorrect based off of vanilla, aside from the duration (which also is correct by the looks of it)? - Area effect clouds...