Levani Khidisheli

Wrong documentation on NewClient

3

Documentation of NewClient states: https://github.com/golang/oauth2/blob/9780585627b5122c8cc9c6a378ac9861507e7551/oauth2.go#L333 However, even if you pass a canceled context into NewClient, it has absolutely no effect. For example: ```go func (c *Config) NewCustomClient(ctx context.Context) *http.Client {...

Caller outputs different path on Windows and Linux

4

If we initialize logger the following way: ```go func newLogger() zerolog.Logger { return zerolog.New(zerolog.ConsoleWriter{ Out: os.Stderr, NoColor: true, TimeFormat: time.StampMicro, PartsOrder: []string{ zerolog.TimestampFieldName, zerolog.LevelFieldName, zerolog.CallerFieldName, zerolog.MessageFieldName, }, }).With().Timestamp().Caller().Logger() } ```...

https://github.com/Masterminds/squirrel/blob/9b18b54aed2aa831665b8e896cde063d51d921fa/placeholder.go#L97-L103 At line 100. since we already know that `len(sql[p:]) > 1` from the previous if check, we know that `len(sql[p:]) == 1` will always be false. unless I'm missing...