Ruki

Also you should note that the smoke for the default classic skin is technically a `LegacySmoke` with it's own smoke texture.

> This is an [osu-resources](https://github.com/ppy/osu-resources/tree/master/osu.Game.Resources/Skins/Legacy) issue though. You can do a PR on [ppy/osu-resources](https://github.com/ppy/osu-resources)

https://osu.ppy.sh/community/forums/topics/129191?n=115

The re-fade animation looks a bit ""chunky"" in this PR. I don't know if this is something which can be fixed looking at how this is implemented. Not a big...

I'm still having hard time figuring out what to do for the tests. `KeysPerSecondCalculator` needs dependencies that I can't find manual alternatives to rely on. If you have any suggestions...

> Tests failing Yes, I do not have the most up-to-date tests locally so I thought that all tests would have passed on CI. Currently working on fixing that. >...

I already see tests failing, but these are not mine, neither the ones I have locally (and on my fork, see [this successful run on my last commit](https://github.com/ItsShamed/osu/actions/runs/2838960286)). There is...

https://github.com/ppy/osu/blob/f29d1b2dedb7062337646c14c16c73465c882fd3/osu.Game.Tests/Skins/SkinDeserialisationTest.cs#L42-L46 I just re-read the test class and got my answer. This is exactly the test that failed. > If this test fails, new test resources should be added to...

I’m pretty sure this term is known by most rhythm gamers or at least the osu! community. Here are some third-party tools commonly used by streamers, they include the term...

CPS seems fines if we want to avoid using the KPS acronym. But it still feels very odd to me, because most of the time inputs are made using the...