Itoro Ukpong

Results 29 comments of Itoro Ukpong

> @msgilligan I'll leave the review of the actual `.kt` file to you, because you seem to be the most invested into the ForwardingService in general. I personally would try...

> One nitpick about the commit message: we use present tense to describe the semantics of the commit, rather than past tense. So "simplify coin listener" rather than "simplified…". Noted....

> I wonder can we do anything about these warnings as well? > > > w: file:///bitcoinj/examples-kotlin/src/main/kotlin/org/bitcoinj/ForwardingService.kt:94:81 Parameter 'prevBalance' is never used > > w: file:///bitcoinj/examples-kotlin/src/main/kotlin/org/bitcoinj/ForwardingService.kt:94:100 Parameter 'newBalance' is never...

> > Obviously we can't change the method signature, but is it possible to declare the parameters as "intentionally not being used"? > > Can't they be replaced with `_`...

I think its a great idea to have examples. Having examples also gives room to explain what we are trying to show (via comments) and gives a direct place for...

I think this relates to [this](https://github.com/bitcoindevkit/bdk-ffi/issues/769#issuecomment-2944323403), and [this](https://github.com/bitcoindevkit/bdk-ffi/issues/769#issuecomment-2949205368). Some example that I have though of showing in a sample folder for kotlin side are; - How we can generate/create descriptors....

I am interested in working on this

Cool! this is so that the content will adapt naturally to the screen

Wondering what the deciding factor for which architecture to run on will be. Maybe most common ?