Pavel Zarecky

@TimoGlastra I'm not very familiar with the internal codebase, but I'm wondering: Is it actually correct that this kind of check is done in this aries library? Wouldn't it make...

OK, now I understand why we have it, and I think I could give it a try to implement a better solution. In order to make it right, the logic...

I agree @swcurran. That would be a much cleaner solution. Do you plan to create a PR for it?

How is this different from the jest `expect(...).toThrow(Error)`? E.g. used here: https://github.com/hyperledger/aries-framework-javascript/blob/main/packages/core/src/modules/ledger/__tests__/IndyPoolService.test.ts#L86

> It would be good to add some more tests, but otherwise this is close to being ready to merge. Did you make any breaking changes in this PR? If...

> What is the status of the did exchange intergration. Is that something we want to add in a separate PR? I guess so. I don't know how to test...

I can confirm that in my case on RN v0.60.5 it is still working, while on 0.61.1 and 0.61.2 I encounter the crash mentioned above (with putMap parameters mismatch, introduced...

> @Iskander508 Did you also grab the latest iOS framework? Otherwise you'll still need an API key for iOS... Yes, this package probably still needs an API key provided. I...

> @Iskander508 Did you manage to get Viro Media working on Android and RN0.60.5... Notice: If using react-viro, you cannot run the app on an x86 device (usually android emulators)!...

> Hi @Iskander508 , in my case is working correctly in Android and RN 0.60.5. (if needed i'll try in 0.61.2 like you) > I've some problem making it works...