Ishaan Desai

Results 51 comments of Ishaan Desai

Good idea! Although I think we should do such checks carefully. In principle pyprecice `v2.3.0.0` should work with preCICE `v2.5.0` as it is only a difference of minor versions. The...

> Why is this PR a draft? No particular reason. This is something that we should do soon anyway. I will look into it again.

@phershbe sure, please fork the repo and open a pull request to the develop branch when you have done the changes. As you have correctly noted, the changes are straightforward...

> think I've cleared up some of my confusion now because the other example mentioned, https://github.com/precice/precice/pull/1548, is regarding https://github.com/precice/precice and this is regarding https://github.com/precice/python-bindings, correct? Correct. `precice/precice` is the repository...

Hi @nkr0, I am trying to understand why the change you have suggested is necessary. Did you install the `pyprecice` in a non-system location? Or is this about preCICE itself...

@nkr0 thanks for the explanation, now its clear what the change does. I think this makes sense, and if I remember correctly, you opened this PR after a discussion with...

Closing this in favor of handling the error message when preCICE has not bee found, in https://github.com/precice/python-bindings/issues/209

Hi @ilovenili Can you give more details on the memory leaks you found? Could you trace them to a specific function in the adapter? How large was the leak?

> This prevents us from polluting compact codes I can provide another example of such polluting code [here](https://github.com/IshaanDesai/fusion-core-coupling/blob/e473193f040c0f79ffbfbdac0e21384ba673e82c/diffusion_core/diffusion_core.pyx). In this code I have a single python script to do the...

This can be achieved for standard flow cases such as lid-driven-cavity flow or 2D channel flow by creating journal files as mentioned here: https://www.afs.enea.it/project/neptunius/docs/fluent/html/ug/node95.htm Once such a journal file is...