python-bindings icon indicating copy to clipboard operation
python-bindings copied to clipboard

Published 20 hours ago • verified publisher icon precice

set PKG_CONFIG_PATH if necessary

Open nkr0 opened this issue 2 years ago • 3 comments

When installed in a non-system location, pkg-config is not able to find the configuration file. According to pkg-config's manual, "the default is libdir/pkgconfig:datadir/pkgconfig where libdir is the libdir where pkg-config and datadir is the datadir where pkg-config was installed."

This PR sets PKG_CONFIG_PATH using LD_LIBRARY_PATH to make finding precice easier.

nkr0 avatar Feb 13 '23 10:02 nkr0

Hi @nkr0,

I am trying to understand why the change you have suggested is necessary. Did you install the pyprecice in a non-system location? Or is this about preCICE itself not being installed in a system known location?

IshaanDesai avatar Mar 20 '23 08:03 IshaanDesai

For when precice is installed in non system places. I'll add a few comments in the file for explanation.

nkr0 avatar Mar 20 '23 09:03 nkr0

@nkr0 thanks for the explanation, now its clear what the change does. I think this makes sense, and if I remember correctly, you opened this PR after a discussion with @fsimonis on Gitter, right?

IshaanDesai avatar Mar 20 '23 15:03 IshaanDesai

Closing this in favor of handling the error message when preCICE has not bee found, in https://github.com/precice/python-bindings/issues/209

IshaanDesai avatar Jul 21 '24 12:07 IshaanDesai