Irakli Janiashvili

Results 75 comments of Irakli Janiashvili

@agha4to oh I see.. we can deal with that separately.

Thank you for the changes, @agha4to. I’ve finished the code review, and it looks great. Tests are all ✅ as well 🙌 !!! There are a few minor bugs that...

I found one major bug: row number appearing in the second column: see the video so you can reproduce on your end: https://github.com/user-attachments/assets/e6c92ff2-203d-47da-a698-9a397fb2bc0b

> Here's a look at all gray column totals / bottom row: ![image](https://private-user-images.githubusercontent.com/138995798/357611711-434b6257-b561-478e-babf-ef8dabd1ede3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwNjgxNjYsIm5iZiI6MTcyNDA2Nzg2NiwicGF0aCI6Ii8xMzg5OTU3OTgvMzU3NjExNzExLTQzNGI2MjU3LWI1NjEtNDc4ZS1iYWJmLWVmOGRhYmQxZWRlMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgxOVQxMTQ0MjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00MGYyYjBlM2NkM2VkMDlmODE1OTk3NTk1NTI0MzY2NzkyOGYzNThiZmEzOGU1OTcwYmRhMDUxNDg0NWI3MzQ0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.BX1qH5VjGJ1g_prBT5SrZhcjCX1hKT_9dyfmCHhHQtE) > > Please also note that in the non-pivot version, the column totals / bottom row is...

> Awesome finds, @IrakliJani! I was able to fix these two but want to test so will push code here hopefully by eow: > > 1. Row number in wrong...

@agha4to sorry for the long pause.. we didn’t have the capacity to give a final review and a QA Is there anything remaining before we approve the code changes? here...

render link: https://lightdash-pr-11681.onrender.com

@agha4to approving code changes ✅ great work 🙌

The customer has requested a feature to manage comment visibility based on user groups, distinguishing between internal users (e.g., those with a company email domain) and external users. They would...