Irakli Janiashvili
Irakli Janiashvili
@agha4to oh I see.. we can deal with that separately.
Thank you for the changes, @agha4to. I’ve finished the code review, and it looks great. Tests are all ✅ as well 🙌 !!! There are a few minor bugs that...
I found one major bug: row number appearing in the second column: see the video so you can reproduce on your end: https://github.com/user-attachments/assets/e6c92ff2-203d-47da-a698-9a397fb2bc0b
> Here's a look at all gray column totals / bottom row:  > > Please also note that in the non-pivot version, the column totals / bottom row is...
> Awesome finds, @IrakliJani! I was able to fix these two but want to test so will push code here hopefully by eow: > > 1. Row number in wrong...
thanks @agha4to 🙌
@agha4to sorry for the long pause.. we didn’t have the capacity to give a final review and a QA Is there anything remaining before we approve the code changes? here...
render link: https://lightdash-pr-11681.onrender.com
@agha4to approving code changes ✅ great work 🙌
The customer has requested a feature to manage comment visibility based on user groups, distinguishing between internal users (e.g., those with a company email domain) and external users. They would...