Michael Carlstrom

Results 24 comments of Michael Carlstrom
trafficstars

Running mypy complains about the type change within ` @property` this doesn't effect the end user and is fine for now until [#mypy300](https://github.com/python/mypy/issues/3004) gets resolved.

> Very nice! There is another working package here: https://github.com/rospypi/rosidl_generator_mypy > > I hope this can be merged and replace the above 🙏 Thank you for working on type annotations....

I believe `message_type = ` should be `String` not `String()`

@clalancette Any update on this? Anything else you want from me?

Strange it cannot find `types-pyaml` error: Library stubs not installed for "yaml" [import-untyped]

Hmm I might be wrong but looking at [this](https://github.com/ros2/ci/pull/773#discussion_r1578297797) we might need to add the install in ros2ci itself.

Made a pr over at https://github.com/ros2/ci/pull/781 to hopefully address this problem.

In my example I have `numpy.ndarray[numpy.float64]` which is what was currently being done to shown the error. You have `numpy.ndarray[Any, numpy.float64]` which is also incorrect. It would need to be...

@timohl I have tried some various things like to get `io_name` working with templated arguments. Is there something obvious I am missing? ```C++ PYBIND11_TYPE_CASTER(type, io_name("numpy.typing.ArrayLike", "numpy.typing.NDArray[" + npy_format_descriptor::name + "]"));...

@timohl I copied over your changes but, I seem to be getting some errors that have to with `tools/FindCatch.cmake`. To me they look unrelated but, maybe I am missing something....