Variable shadowing

[Heerdam]

Greetings.

I want to to bring an issue with your code to your attention. Specifically it is the issue that various variables are shadowing class members or even local variables shadowing other local variables. (For example here) While this is technically not an error according to C++ standard, this is considered bad practice and compilation fails with '-Wshadow -Werror' on gcc or when using MSVC with /WX (or any warning is error flag enabled) and the conformance mode (/permissive-) enabled.

Cheers

[JoseAntFer]

Hello @Heerdam,

please excuse the late response. I finally found some time to take a look at this. While I understand that this is not good practice, it doesn't affect the correct functioning of the library and it is not something I can spend time to address at the moment. Also, many of those warnings are coming from a 3rd party library (taskflow), so TreeNSearch will not compile with "-Werror" even if we fix the ones on our end.

In any case, we appreciate your feedback and we will take it into account for when we have time.

Best regards, José.