Ted John

Results 47 comments of Ted John

I don't like precompiled headers... can we instead just work on reducing the use of common.h?

> I was under impression using MSVC requires the mindset to yearn for PCHs. I generally find them a nuisance. They require some odd requirements sometimes like needing it to...

> Not at all, the services should all be there like they are currently, but I need them done in a dependency injection style, so everything should come from context....

Seeing these kinds of things implemented in C++ always makes me cry, when comparing them to other languages. For example, the fact you have to duplicate all the signatures of...

Can you show how it looks when you have more tabs, enough to overflow the window? How do you select ones that are hidden?

A simple solution (even without changing the tab orientation) is to have a dropdown that changes the selection of tabs. For example you could have different dropdown items for RCT1,...

> I get the feeling this PR is suffering from extensive bikeshedding. Can we please get back on track? I am not sure what the benefit of changing the orientation...

I am not too bothered about this, it is just a warning. Realistically we can't do it for every build.

https://github.com/OpenRCT2/OpenRCT2/wiki/Master-Server