LibCST icon indicating copy to clipboard operation
LibCST copied to clipboard

Published 20 hours ago • verified publisher icon Instagram

Steal tests from retype for ApplyTypeAnnotationsVisitor

Open hauntsaninja opened this issue 4 years ago • 1 comments

(copy of https://github.com/Instagram/MonkeyType/issues/199, with context of fairly major regression fixed in https://github.com/Instagram/LibCST/pull/314 / https://github.com/Instagram/MonkeyType/issues/198)

Given the new importance of ApplyTypeAnnotationsVisitor to MonkeyType, we should try and improve test coverage of ApplyTypeAnnotationsVisitor. To that end, it might be worth stealing the test cases from https://github.com/ambv/retype/blob/master/tests/test_retype.py

hauntsaninja avatar Jun 17 '20 00:06 hauntsaninja

The test cases there look comprehensive and you're welcome to port them to LibCST!

CC @pradeep90 who worked on ApplyTypeAnnotationsVisitor

jimmylai avatar Jun 17 '20 03:06 jimmylai