ITK

ITK copied to clipboard

Incorrect call when comparing matrices in nifti headers

6

### Description In this code transpose is used when inverse is intended: https://github.com/InsightSoftwareConsortium/ITK/blob/7357008cbc2880cda302f00efd1a39b02aeffe08/Modules/IO/NIFTI/src/itkNiftiImageIO.cxx#L1978-L1982 It looks to me like the code was copy-pasted from above where transpose was intended but the...

pieper

Nifti volume of specific size + Shrink filter cause segmentation fault

21

### Description The combination of NIFTI + Shrink filter causes a segmentation fault for some dimensions and sizes. ### Steps to Reproduce (MVE) 1. Generate a nifti volume of the...

okmiim

Decide whether the trigger would be size of 1, 2 or 4GB. See [nifti2_doc](https://www.nitrc.org/docman/view.php/26/1302/nifti2_doc.html) and ITK forum [discussion](https://discourse.itk.org/t/nifti-1-or-nifti-2-data-format/4330) about it.

dzenanz

WIP: Remove non-const overload of `Object::AddObserver`, add `mutable`

13

Declared m_SubjectImplementation `mutable` (just like m_MetaDataDictionary), in order to avoid a `const_cast` in the `const` overload of `Object::AddObserver`. Removed the non-const overload, as it is semantically just the same as...

N-Dekker

Replaced `make_unique_for_overwrite` calls with `std::make_unique`, whenever the elements of the allocated buffer need to be zero-initialized. Removed "post-initializations" which did assign zero to these elements.

N-Dekker

Might slightly speedup the code. Note that those two local buffers were already there before `make_unique_for_overwrite` was introduced.

N-Dekker

DCMTK tests failing

6

The following tests are failing when DCMTKImageIO is enabled: 963 - itkDCMTKImageIOTest1 (Failed) 965 - itkDCMTKImageIOTest3 (Failed) 968 - itkDCMTKDirCosinesTest (Failed) 976 - itkDCMTKImageIOSlopeInterceptTest (Failed) 977 - itkDCMTKImageIONoPreambleTest (Failed) Running...

blowekamp

Apologies for cross-posting but activity on this thread in the ants github has stalled. https://github.com/ANTsX/ANTs/issues/1017 When using bsplinesyn registration in ANTs, which uses bspline code in ITK, multithreading is very...

chrisadamsonmcri

STYLE: Declare BlockMatchingImageFilter data members as unique_ptr<T[]>

3

N-Dekker

DOC: Remove Doxygen `\ref` command in module description

3

Remove group/module linking Doxygen `\ref` command in module description. Non-working as-is. Introduced in commit a0d0b4c. ## PR Checklist - [X] No [API changes](https://github.com/InsightSoftwareConsortium/ITK/blob/master/CONTRIBUTING.md#breaking-changes) were made (or the changes have been...

jhlegarreta