Infernio

Results 249 comments of Infernio

@lojack5 I went ahead and deleted `lojack-vmad` now that my revived version of it has been merged - just to let you know so you don't end up wondering where...

> loadData size_ parameter is seldom used and some of the uses are marked with todos. Would simplify the API to drop it but would it make it too weak?...

> note by the way \_\_author__ should be placed after the module docstring but before any import statements except from future imports Ah, that makes sense. IIRC Ganda added the...

> maybe drop keep and directly use self.keepIds.add ? Do you mean something like this? ```diff def getKeeper(self): + return self.keepIds.add - def keep(fid): - self.keepIds.add(fid) - return fid -...

Took a look over `utumno-records-renames`, and it all seems fine to me. I don't have access to a Windows machine right now, and I'd rather not send wine-built nightlies to...

> I renamed MreHeader to MreTes4, that I think should make it to dev soon I'm unsure how we should handle that with Morrowind though - there is a bunch...

Just had a look (on nightly), three usages use it as a constructor, four use it to get the `classType`. Maybe `bush.game.main_header_class` instead? `MreHeader` as a variable looks misleading.

@Utumno [Someone reported this code erroring out](https://www.afkmods.com/index.php?/topic/4966-wrye-bash-all-games/page/84/&tab=comments#comment-176834). Not sure how they managed to get hold of a file with an invalid header signature, but still: ```python raise exception.ModError(ins.inName, u'Bad header...

LoadFactory doesn't really do much - the entire class can probably go at some point? Not sure, at least it could use a pass to clean up all those weird...

See #312, point `initData is horribly slow due to constantly load()ing the same files, once for each patcher`. Ideally we'd only read each file once (over the entire BP process...