Mikhail Leliakin comments

Results 27 comments of


                                            Mikhail Leliakin

Document how to make a custom title bar on macOS respect native double-click behavior

Is it something what is provided by Electron? I have the following fiddle: https://gist.github.com/Imperat/52edd8a1a8a928d71426fb55f30902a3 I do not have any implementation for the native double-click behavior, however, I am still able...

Missing `Http2ServerResponse.setHeaders()` fixed

Hi @jakecastelli @mcollina Thanks for having a look at this PR :pray: I've updated linting, merged the latest `main` branch and applied suggestions from @meyfa Hi @mcollina > Can you...

Shutting Electron leaves hanging process which prevents reopening app

Hi @wbosley Could you please share how many processes do users have in hanging state? I noticed similar issue with Electron 35.0.1 where user have a triple of processes (maybe...

BundleVersion and BundleShortVersion often not used

Bump please. I encountered this myself when trying to submit multiple builds to Mac App Store with different `bundleVersion` but the same `bundleShortVersion`. I use electron-builder v26.0.1. In macPackager.ts I...

feat: Add optional `outputSize` to `opts` of `webContents.capturePage([rect, opts])`

cc @ckerr @codebytere @zcbenz

feat: Add optional `outputSize` to `opts` of `webContents.capturePage([rect, opts])`

Hi @ckerr @codebytere Thanks for reviewing this PR 🙏 I've added two tests to `spec/api-browser-view-spec.ts` and `spec/api-browser-window-spec.ts`. I was unable to run all of the tests via `npm test` (it...

feat: Add optional `outputSize` to `opts` of `webContents.capturePage([rect, opts])`

Hi @jkleinsc @nornagon Thank you for your feedback. I apologize for not being able to update the PR earlier when I received your review. I made some changes now. Could...